Add mock discovery tests for WildFly 39, 40, and 41 - #742
Merged
robstryker merged 6 commits intoAug 8, 2026
Conversation
Verify that the existing WildFly 38+ server adapter correctly discovers and claims WildFly 39.0.1, 40.0.1, and 41.0.0 installations via the ServerBeanTypeWildflyPlus catch-all mechanism, without requiring new server type definitions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The switch statement was missing cases for SERVER_WILDFLY_350 and SERVER_WILDFLY_380, causing integration tests to fall through to the WF 12 default and fail ServerHandle equality checks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Also fix getRuntimeById() which ignored its id parameter and always filtered for the hardcoded WF 18 runtime id. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…uickstarts WF 38 quickstarts require Java 17 to compile, but CI runs Java 11. Configure maven-invoker-plugin with a javaHome property so the quickstart builds can use a different JDK. Upgrade the plugin from 3.2.0 to 3.8.1 to fix compatibility with Maven 3.9.x. Update the CI workflow to set up Java 17 alongside Java 11 and pass -Dinvoker.javaHome to the build. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
WF 38 requires Java 17+ to run, but the RSP server and CI build use Java 11. Add a server.vm.install.path property that the tests pass as vm.install.path when creating and starting servers, so the RSP launches WildFly with a different JDK than its own. CI sets this to $JAVA_HOME_17_X64. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ServerBeanTypeWildflyPlus) adaptercanHandleVersioncatch-all logic correctly claims these versions since 38 is the highest registered adapterJBossServerBeanLoaderTestgoes from 45 to 48 parameterized cases (all green)Test plan
mvn verify -pl runtimes/tests/org.jboss.tools.rsp.server.wildfly.test -am— 133 tests, 0 failures🤖 Generated with Claude Code