fix(ci): extract version from tag for Homebrew formula update #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mislav/bump-homebrew-formula-action compares formula version against the tag-name to determine if an update is needed. With our tag format 'redisctl-v0.7.3', the action was comparing '0.7.2' (from formula) against 'redisctl-v0.7.3' and incorrectly determining that 0.7.2 is newer. This fix extracts just the version number (e.g., '0.7.3') from the full tag name and passes 'v0.7.3' to the action for proper comparison, while keeping the original tag for the download URL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
mislav/bump-homebrew-formula-actioncompares the formula version against thetag-nameparameter to determine if an update is needed. With our tag formatredisctl-v0.7.3, the action was comparing0.7.2(from formula) againstredisctl-v0.7.3and incorrectly determining that 0.7.2 is newer (string comparison issue with the prefix).Solution
Add a step to extract just the version number from the full tag name:
redisctl-v0.7.3→0.7.3v0.7.3to the action'stag-nameparameter for proper version comparisonredisctl-v0.7.3) for thedownload-urlsince that's where the artifacts areTesting
This will be tested on the next release. The workflow syntax is valid.