Fix hosted MCP token minting in no-auth mode#8
Merged
rowantrollope merged 1 commit intomainfrom May 5, 2026
Merged
Conversation
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In self-managed no-auth mode, a control-plane MCP token could already do useful control-plane work such as listing or creating workspaces, but it failed at the next required step:
mcp_token_issuereturnedauthentication required.That left the hosted MCP flow internally inconsistent:
fs.mount()stayed broken for SDK clients that depend on that handoffIn practice, this blocked the mounted-filesystem path for the SDKs even though the rest of the hosted control-plane token flow looked healthy.
Fix
mcp_token_issue-> workspace token worksFSClient.mount()so the SDK path that originally exposed the problem stays coveredWhy the extra test changes are here
This branch also updates two stale
cmd/afstests that were already failing the local repo gate for unrelated reasons:-wfilesystem flagThose changes do not alter product behavior. They make the existing test gate reflect the actual branch state so the PR can run cleanly.
Testing
go test ./cmd/afs -run 'TestCmdStatusShowsSignedInCloudState|TestCmdFSHistoryReportsExistingFileWithoutRecordedHistory'go test ./internal/controlplanePYTHONPATH=src uv run python -m unittest tests.test_clientmake testuv run --with build --with twine python -m builduv run --with twine python -m twine check dist/*