Skip to content

Improve chord memory card text prompt typography #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rednebmas wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Improve chord memory card text prompt typography #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f37e8be
Improve chord memory card text prompt typography
rednebmas Mar 3, 2026
a973662
Move options menu from absolute overlay to flow-based header row
rednebmas Mar 3, 2026
f1e5103
Revert to absolute menu, use heading-md for plain text prompts
rednebmas Mar 3, 2026
e0ca0b1
Fix card layout: use flow-based header row for options menu
rednebmas Mar 3, 2026
9bf6fef
Fix menu row: fully collapse with -mb-9, restore justify-between
rednebmas Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/react/src/components/FlashCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,13 @@ export const FlashCard = forwardRef<HTMLDivElement, FlashCardProps>(
return (
<div
ref={ref}
className={`relative card-container flex flex-col justify-between items-center min-w-[15rem] m-h-60 m-4 ${className}`}
className={`card-container flex flex-col justify-between items-center min-w-[15rem] m-h-60 m-4 ${className}`}
style={{
opacity,
transition: 'opacity 0.5s ease',
}}
>
<div className="absolute right-1 top-1">
<div className="relative z-10 w-full flex justify-end -mb-9">
<FlashCardOptionsMenu card={card} showEdit={showEdit} showDelete={showDelete} />
</div>
<div className="text-4xl font-medium flex flex-1 justify-center items-center">
Expand Down
9 changes: 8 additions & 1 deletion apps/react/src/components/FlashCards/TextCardPrompt.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,14 @@ export const TextCardPrompt: React.FC<TextCardPromptProps> = ({
correctCount = 0,
}) => (
<div className="flex flex-col items-center justify-center text-center gap-2">
<ReactMarkdown className="prose prose-sm max-w-none dark:prose-invert pt-3">
<ReactMarkdown
className="max-w-none pt-3 flex flex-col items-center gap-1"
components={{
h1: ({ children }) => <p className="heading-lg">{children}</p>,
h2: ({ children }) => <p className="caption">{children}</p>,
p: ({ children }) => <p className="heading-md">{children}</p>,
}}
>
{text}
</ReactMarkdown>
<div className="mb-auto">
Expand Down
Loading