Skip to content

feat: [resolves #145] &OrderedFloat <op> &OrderedFloat impl workaround #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mbrubeck merged 2 commits into from
Nov 3, 2024
Merged

feat: [resolves #145] &OrderedFloat <op> &OrderedFloat impl workaround #162

mbrubeck merged 2 commits into from
Nov 3, 2024

Conversation

@gechelberger
Copy link

@gechelberger gechelberger commented Nov 3, 2024

Given the problems with a pure delegated impl, add a Copy bound and LLVM will probably optimize it away anyways.

@gechelberger
Copy link
Author

gechelberger commented Nov 3, 2024

Specifically, have the trait solver look for T: Add<T> which is already supported without issue instead of &T: Add<&T> which causes the trait solver to recursively explode.

issue #145
issue #91

mbrubeck
mbrubeck approved these changes Nov 3, 2024
View reviewed changes
Copy link
Collaborator

@mbrubeck mbrubeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mbrubeck mbrubeck merged commit 49f8f9d into reem:master Nov 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbrubeck mbrubeck mbrubeck approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gechelberger @mbrubeck