ENG-8657: Fix broken links on hosting page

[carlosabadia]

No description provided.

[linear]

ENG-8657 Fix broken templates links on /hosting page

[greptile-apps]

Greptile Overview

Greptile Summary

This PR fixes broken links on the hosting page by ensuring URL generation correctly handles template titles containing underscores. The fix adds .replace('_', '-') to match the slug generation logic in apps.py:266, which uses re.sub(r"[\s_]+", "-", ...) to convert both spaces and underscores to hyphens.

Impact:

• Fixes broken links for templates like api_admin_panel, customer_data_app, ci_template, and ai_image_gen
• Users can now successfully navigate from the hosting page to these template detail pages
• The URL generation is now consistent between the hosting page card links and the actual route definitions

Confidence Score: 5/5

• This PR is safe to merge with no risk
• The change is a simple, well-targeted fix that adds underscore replacement to match existing slug generation logic. The fix is minimal (single character addition), addresses a clear bug (broken links), and aligns with the established pattern in apps.py. No custom rules are violated, and the change has no side effects.
• No files require special attention

Important Files Changed

Filename	Overview
pcweb/pages/hosting/views/templates.py	Added underscore-to-hyphen replacement to fix broken links for templates with underscores in their titles (e.g., api_admin_panel, customer_data_app). Change aligns URL generation with the slug generation logic in apps.py.

Sequence Diagram

sequenceDiagram
    participant User
    participant HostingPage as Hosting Page (templates.py)
    participant GalleryApp as Gallery App (apps.py)
    participant TemplateDoc as Template Document
    
    User->>HostingPage: Visit hosting page
    HostingPage->>TemplateDoc: Load template metadata
    Note over TemplateDoc: title: "api_admin_panel"
    HostingPage->>HostingPage: Set url = title
    Note over HostingPage: url: "api_admin_panel"
    HostingPage->>HostingPage: Generate href for link
    Note over HostingPage: Before: replace(' ', '-')<br/>Result: "api_admin_panel" ❌<br/><br/>After: replace(' ', '-').replace('_', '-')<br/>Result: "api-admin-panel" ✓
    HostingPage->>User: Render link with href
    User->>GalleryApp: Click link to template
    GalleryApp->>GalleryApp: Generate route slug
    Note over GalleryApp: re.sub(r"[\s_]+", "-", title)<br/>Result: "api-admin-panel"
    GalleryApp->>User: Display template page (route matches!)

Loading

[greptile-apps]

_{No files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}