Skip to content

Conversation

@carlosabadia
Copy link
Collaborator

No description provided.

@linear
Copy link

linear bot commented Jan 30, 2026

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 30, 2026

Greptile Overview

Greptile Summary

This PR updates HTML component documentation to use lowercase naming convention (e.g., rx.el.a instead of rx.el.A) to match the actual component API and align with HTML standards.

Key changes:

  • Updated 89 component names in docs/library/other/html.md from PascalCase to lowercase
  • rx.el.Del remains capitalized in metadata (since del is a Python reserved keyword)
  • Added display name mapping in pcweb/pages/docs/component.py to render rx.el.Del as rx.el.del in documentation

This ensures documentation matches the actual code usage throughout the codebase, where components are already invoked using lowercase names (e.g., rx.el.button(), rx.el.a()).

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • Documentation-only change that corrects component naming to match actual API usage. The special handling for rx.el.Del is correctly implemented to work around Python's reserved keyword.
  • No files require special attention

Important Files Changed

Filename Overview
docs/library/other/html.md Changed HTML component names from PascalCase to lowercase (e.g., rx.el.Arx.el.a), except rx.el.Del which remains capitalized as it's a Python reserved keyword
pcweb/pages/docs/component.py Added component_display_name_map to map rx.el.Delrx.el.del for display purposes, maintaining consistency with other lowercase component names

Sequence Diagram

sequenceDiagram
    participant MD as html.md (metadata)
    participant Init as __init__.py
    participant Comp as component.py
    participant Display as Rendered Docs
    
    MD->>Init: components: ["rx.el.a", "rx.el.Del", ...]
    Init->>Init: get_components_from_metadata()
    Init->>Init: eval(comp_str) → (class, "rx.el.Del")
    Init->>Comp: component_tuple = (class, "rx.el.Del")
    Comp->>Comp: Check component_display_name_map
    Comp->>Comp: Map "rx.el.Del" → "rx.el.del"
    Comp->>Display: h2_comp(text="rx.el.del")
    Display->>Display: Show lowercase "rx.el.del" to users
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@Kastier1 Kastier1 merged commit a421b90 into main Jan 30, 2026
10 checks passed
@Kastier1 Kastier1 deleted the carlos/fix-html-components-name branch January 30, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants