-
Notifications
You must be signed in to change notification settings - Fork 231
Update base_vars.md #1748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update base_vars.md #1748
Conversation
# index.py
from .state import TickerState
def ticker_example():
return rx.center(
rx.vstack(
rx.heading(TickerState.ticker, size="3"),
rx.text(
f"Current Price: reflex___state____state__flexdown___modules____a4e3de79f19b87b4f4fce3d5f729c6b6b225d8d968533932d2e49adf411f2694____ticker_state.price_rx_state_",
font_size="md",
),
rx.text("Change: 4%", color="green"),
),
)
rendered code doesn't work properly. see this part "f"Current Price: reflex___state____state__flexdown___modules____a4e3de79f19b87b4f4fce3d5f729c6b6b225d8d968533932d2e49adf411f2694____ticker_state.price_rx_state_"
Greptile OverviewGreptile SummaryThis PR adds a screenshot to the documentation showing a bug where state variable references render as garbled text ( Issues identified:
Confidence Score: 1/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Author
participant Docs as docs/vars/base_vars.md
participant Reader as Documentation Reader
Author->>Docs: Add screenshot at top of file
Note over Docs: Screenshot shows bug with<br/>garbled state variable reference
Author->>Docs: Add trailing newline at EOF
Reader->>Docs: Read documentation
Docs->>Reader: Display screenshot showing bug
Note over Reader: Expects bug fix,<br/>receives bug documentation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
| @@ -1,3 +1,4 @@ | |||
| <img width="773" height="434" alt="2026-02-04_09-14-07" src="https://github.com/user-attachments/assets/40614945-af51-4e73-b5b6-01a190ad1a84" /> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Screenshot added without explanation. PR description mentions a bug with rendered code showing reflex___state____state__flexdown___modules____a4e3de79f19b87b4f4fce3d5f729c6b6b225d8d968533932d2e49adf411f2694____ticker_state.price_rx_state_ instead of {TickerState.price}, but this PR only adds the screenshot - it doesn't fix the bug. If this is documenting a bug, should be in an issue tracker, not in the documentation file.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/vars/base_vars.md
Line: 1:1
Comment:
Screenshot added without explanation. PR description mentions a bug with rendered code showing `reflex___state____state__flexdown___modules____a4e3de79f19b87b4f4fce3d5f729c6b6b225d8d968533932d2e49adf411f2694____ticker_state.price_rx_state_` instead of `{TickerState.price}`, but this PR only adds the screenshot - it doesn't fix the bug. If this is documenting a bug, should be in an issue tracker, not in the documentation file.
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise.|
Fixed in #1749 thanks for reporting |
index.py
from .state import TickerState
def ticker_example():
return rx.center(
rx.vstack(
rx.heading(TickerState.ticker, size="3"),
rx.text(
f"Current Price: reflex___state____state__flexdown___modules____a4e3de79f19b87b4f4fce3d5f729c6b6b225d8d968533932d2e49adf411f2694____ticker_state.price_rx_state_",
font_size="md",
),
rx.text("Change: 4%", color="green"),
),
)
rendered code doesn't work properly. see this part "f"Current Price: reflex___state____state__flexdown___modules____a4e3de79f19b87b4f4fce3d5f729c6b6b225d8d968533932d2e49adf411f2694____ticker_state.price_rx_state_"