Skip to content

Use homogenous tuple annotation in BaseStateMeta.__new__ #6096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
masenf wants to merge 4 commits into
base: main
Choose a base branch
from
+5 −3
Open

Use homogenous tuple annotation in BaseStateMeta.__new__ #6096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
566b9a6
Use homogenous tuple annotation in BaseStateMeta.__new__
masenf Jan 21, 2026
cda9c50
Merge remote-tracking branch 'origin/main' into masenf/base-state-met…
masenf Jan 28, 2026
1c45174
update tuple[type, ...] in other places it was used
masenf Jan 28, 2026
7ae0560
precommit
masenf Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions reflex/components/field.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,9 @@ class FieldBasedMeta(type):
PropsBaseMeta and BaseComponentMeta.
"""

def __new__(cls, name: str, bases: tuple[type], namespace: dict[str, Any]) -> type:
def __new__(
cls, name: str, bases: tuple[type, ...], namespace: dict[str, Any]
) -> type:
"""Create a new field-based class.

Args:
Expand Down Expand Up @@ -100,7 +102,7 @@ def __new__(cls, name: str, bases: tuple[type], namespace: dict[str, Any]) -> ty
return super().__new__(cls, name, bases, namespace)

@classmethod
def _collect_inherited_fields(cls, bases: tuple[type]) -> dict[str, Any]:
def _collect_inherited_fields(cls, bases: tuple[type, ...]) -> dict[str, Any]:
inherited_fields: dict[str, Any] = {}

# Collect inherited fields from base classes
Expand Down
2 changes: 1 addition & 1 deletion reflex/vars/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3537,7 +3537,7 @@ class BaseStateMeta(ABCMeta):
def __new__(
cls,
name: str,
bases: tuple[type],
bases: tuple[type, ...],
Copy link
Contributor

@greptile-apps greptile-apps bot Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Same issue exists in reflex/components/field.py:70 where FieldBasedMeta.__new__ still uses tuple[type] instead of tuple[type, ...]

Prompt To Fix With AI 
This is a comment left during a code review.
Path: reflex/vars/base.py
Line: 3540:3540

Comment:
**style:** Same issue exists in `reflex/components/field.py:70` where `FieldBasedMeta.__new__` still uses `tuple[type]` instead of `tuple[type, ...]`

How can I resolve this? If you propose a fix, please make it concise.

namespace: dict[str, Any],
mixin: bool = False,
) -> type:
Expand Down
Loading