Skip to content

Conversation

@MatthewCollinsNZ
Copy link
Contributor

Adding the ability to use the built in glide data grid search bar.

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 3, 2026

Merging this PR will not alter performance

✅ 8 untouched benchmarks


Comparing MatthewCollinsNZ:data_editor_search_props (72549ae) with main (5d1d6db)

Open in CodSpeed

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 3, 2026

Greptile Overview

Greptile Summary

Added built-in search functionality to the DataEditor component by exposing glide-data-grid's native search capabilities.

  • Added show_search prop to toggle the search bar visibility
  • Added on_search_close event handler to respond when users close the search bar
  • Updated pyi_hashes.json to reflect the interface changes
  • Follows existing component patterns (similar to other boolean visibility props and no-args event handlers)

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are minimal, well-contained, and follow established patterns in the codebase. The implementation adds two new properties to expose existing glide-data-grid functionality without modifying any logic or introducing breaking changes.
  • No files require special attention

Important Files Changed

Filename Overview
reflex/components/datadisplay/dataeditor.py Added show_search boolean prop and on_search_close event handler to expose glide-data-grid's built-in search functionality
pyi_hashes.json Updated hash for dataeditor.pyi to reflect interface changes

Sequence Diagram

sequenceDiagram
    participant User
    participant DataEditor
    participant GlideDataGrid
    participant EventHandler

    User->>DataEditor: Set show_search=True
    DataEditor->>GlideDataGrid: Render with showSearch prop
    GlideDataGrid->>User: Display search bar
    User->>GlideDataGrid: Interact with search bar
    GlideDataGrid->>GlideDataGrid: Filter/search data
    User->>GlideDataGrid: Click close button
    GlideDataGrid->>EventHandler: Trigger onSearchClose event
    EventHandler->>DataEditor: Execute on_search_close handler
    DataEditor->>User: Process search close action
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant