-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(exec): correct frontend URL when frontend_path lacks a leading slash (#6360) #6446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
ChinmayShringi
wants to merge
2
commits into
reflex-dev:main
from
ChinmayShringi:fix/frontend-path-no-leading-slash-6360
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| """Tests for reflex.utils.exec.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import pytest | ||
|
|
||
| from reflex.utils.exec import _apply_frontend_path | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| ("listening_url", "frontend_path", "expected"), | ||
| [ | ||
| # Empty frontend_path is a no-op. | ||
| ("http://localhost:3001/", "", "http://localhost:3001/"), | ||
| # Root path "/" must also be a no-op (would otherwise produce "//", a | ||
| # protocol-relative reference that strips the host). | ||
| ("http://localhost:3001/", "/", "http://localhost:3001/"), | ||
| ("http://localhost:3001/", "//", "http://localhost:3001/"), | ||
| # Vite has not yet baked the path into the URL (e.g. prod listening line). | ||
| ("http://localhost:3001/", "/app", "http://localhost:3001/app/"), | ||
| ("http://localhost:3001/", "app", "http://localhost:3001/app/"), | ||
| ("http://localhost:3001/", "app/", "http://localhost:3001/app/"), | ||
| ("http://localhost:3001/", "/app/", "http://localhost:3001/app/"), | ||
| # Vite already prints the URL with the base appended (dev server). | ||
| # Either form of frontend_path must NOT cause the path to be duplicated. | ||
| ("http://localhost:3001/noslash/", "noslash", "http://localhost:3001/noslash/"), | ||
| ( | ||
| "http://localhost:3001/noslash/", | ||
| "/noslash", | ||
| "http://localhost:3001/noslash/", | ||
| ), | ||
| # Multi-segment frontend_path. | ||
| ( | ||
| "http://localhost:3001/", | ||
| "app/v1", | ||
| "http://localhost:3001/app/v1/", | ||
| ), | ||
| ( | ||
| "http://localhost:3001/app/v1/", | ||
| "app/v1", | ||
| "http://localhost:3001/app/v1/", | ||
| ), | ||
| ], | ||
| ) | ||
| def test_apply_frontend_path(listening_url: str, frontend_path: str, expected: str): | ||
| """Issue #6360: frontend_path without a leading slash must not duplicate path segments.""" | ||
| assert _apply_frontend_path(listening_url, frontend_path) == expected |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
frontend_path = "/"produces"//"When
frontend_pathis exactly"/","/".strip("/")yields"", sonormalizedbecomes"//". Passing"//"tourljointreats it as a network-path (protocol-relative) reference, which strips the host and produces a broken URL like"http://"instead of"http://localhost:3001/".A simple guard handles it: