Minimize cross-package dependencies in component packages#6515
Draft
Alek99 wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reflexpackage soreflex-components-coreno longer depends on Lucide or Sonner for that module.loading_iconas a genericComponent.reflex-components-corevia the existing toast ref instead of importing Sonner directly.Connection Banner Visual Check
The connection banner should look the same as before. I tested
origin/mainand this PR branch with the same fixture, viewport, light page background, and forced websocket disconnect. The only expected text difference is the dynamic local websocket port.I also compared the rendered output for
ConnectionBanner,ConnectionModal, andConnectionPulseragainstorigin/main; all matched.Validation
uv run ruff format --check reflex/components/banner.py reflex/app.py reflex/utils/codespaces.py packages/reflex-components-core/src/reflex_components_core/core/__init__.py packages/reflex-components-core/src/reflex_components_core/core/upload.py packages/reflex-components-sonner/src/reflex_components_sonner/toast.py tests/units/components/core/test_banner.py tests/units/components/test_package_dependencies.pyuv run ruff check reflex/components/banner.py reflex/app.py reflex/utils/codespaces.py packages/reflex-components-core/src/reflex_components_core/core/__init__.py packages/reflex-components-core/src/reflex_components_core/core/upload.py packages/reflex-components-sonner/src/reflex_components_sonner/toast.py tests/units/components/core/test_banner.py tests/units/components/test_package_dependencies.pyuv run pytest tests/units/components/core/test_banner.py tests/units/components/core/test_upload.py tests/units/components/test_package_dependencies.pyuv run pyright packages/reflex-components-sonner/src/reflex_components_sonner/toast.py packages/reflex-components-core/src/reflex_components_core/core/upload.py reflex/components/banner.pyorigin/mainforConnectionBanner,ConnectionModal, andConnectionPulserorigin/mainwith the same forced-disconnect fixtureFixes #6324