Restore pyplot getter semantics for limits and ticks - #470
Conversation
|
Implemented and pushed in commit The change restores Matplotlib-style getter/setter behavior for Validation passed for the focused issue tests, |
📝 WalkthroughWalkthroughChangesPyplot return-value semantics
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Greptile SummaryRestores Matplotlib-style getter and return-value semantics for pyplot limits, ticks, and legends.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previously reported minor-tick getter now selects minor locations and minor label handles without entering the setter path.
|
| Filename | Overview |
|---|---|
| python/xy/pyplot/init.py | Adds public getter/setter return semantics and correctly routes minor tick getter requests. |
| python/xy/pyplot/_axes.py | Makes limit and tick setters return their resulting limits or label handles while preserving non-mutating limit getters. |
| python/xy/pyplot/_plot_types.py | Aligns mixin type declarations with the updated Axes return contracts. |
| tests/pyplot/test_reference_semantics.py | Adds regression coverage for limit getters, tick getters, minor tick routing, setter returns, and live legend handles. |
Reviews (2): Last reviewed commit: "Fix pyplot minor tick getters" | Re-trigger Greptile
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
Fixes #443
Summary
xlimandylim.xticksandyticksgetters non-mutating and return locations plus label handles.Legendhandle frompyplot.legendwith the correct annotation.Axesreturn types and add reference-semantic regression tests.Validation
The full local pyplot invocation also includes pre-existing Windows-environment failures in subprocess import setup, source-file encoding scans, and the optional pandas Matplotlib backend.
Summary by CodeRabbit
New Features
Bug Fixes