Remove the vestigial include/libhc submodule gitlink - #14
Merged
Conversation
The flake supplies hypercall.h from its own libhc input (mk-busybox.nix drops it into include/libhc/ during postPatch), so the submodule has been dead weight since the self-building flake landed. It is also actively harmful downstream: a codeload tarball of this repo packs the gitlink in a way registry proxies can repack differently from a plain fetch, giving an environment-dependent narHash -- which forces penguin to pin busybox via git+https...&submodules=1 instead of a plain github:rehosting/busybox/<tag> flake input. Verified: nix build .#dist from this tree cross-builds all arches (static musl binaries, spot-checked armel).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flake supplies
hypercall.hfrom its ownlibhcinput (mk-busybox.nixdrops it intoinclude/libhc/during postPatch), so the.gitmodulesentry and theinclude/libhcgitlink have been dead weight since the self-building flake landed.They're also actively harmful downstream: a codeload tarball of this repo packs the gitlink in a way registry proxies can repack differently from a plain fetch, giving an environment-dependent narHash. That's why penguin currently pins busybox via
git+https://...?ref=refs/tags/vX&rev=...&submodules=1instead of a plaingithub:rehosting/busybox/<tag>input like the other guest tools.Verified:
nix build .#distfrom this tree cross-builds all arches (static musl binaries, spot-checked armel = ELF 32-bit LSB ARM).Follow-up after merge + next version tag: switch penguin's
busyboxflake input to the plaingithub:tag pin and drop the git+https workaround.