Generic NodeID implementation v2 #249
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated Node and Channel structures to use generics for node IDs. - Modified sorting functions in node_test.go to accommodate the new generic Node type. - Changed managerOptions to accept a generic function for per-node metadata. - Refactored QuorumCall and related functions to support generic node ID types. - Adjusted Responses and ResponseSeq types to work with generics. - Updated tests in quorumcall_test.go and responses_test.go to reflect changes in node ID handling. - Enhanced Unicast function to utilize generics for node IDs. - Made necessary adjustments in server_test.go and testing_bufconn.go for compatibility with the new generic structure.
Just node_id could be confusing, so we use node_id_type to make sure it is clear that this is the NodeID type (uint32, int64, string etc.)
All other methods use (c Configuration[T]) as the receiver for configuration methods; so we should do the same for the Context methods as well.
Removing NodeID from nodeError may marginally reduce churn, but it is unclear whether the improvement is significant enough to matter.
Contributor
|
Here's the code health analysis summary for commits Analysis Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #165
This builds on #248, but with the
NodeIDtype parameter removed fromnodeError.Removing
NodeIDfromnodeErrormay marginally reduce churn, but it is unclear whether the improvement is significant enough to matter.