Conversation
dgsasha
force-pushed
the
windows
branch
2 times, most recently
from
de3c20f to
62d03a7
Compare
Collaborator
Author
|
This should be ready to merge once I test that this didn't break anything on Linux. |
Collaborator
Author
|
|
Collaborator
Author
|
This is exceptionally laggy under UWP for some reason, gonna have to work on it some more. Other than that everything works fine, but I am very confident I broke things on linux lol. |
Collaborator
Author
|
I should have known, microsoft just doesn't allow the use of anything other than directx on UWP, even for desktop apps that don't release on Xbox. I think this will fix it though. Edit: Seems like it increases memory usage but whatever, this is the only way I'm getting things working. Maybe I should give up on the microsoft store tbh. |
dgsasha
force-pushed
the
windows
branch
2 times, most recently
from
1975bd1 to
3279705
Compare
Collaborator
Author
|
Need to test this on linux, other than that it should be good to go. Merging tomorrow and releasing a new beta tomorrow. |
dgsasha
force-pushed
the
windows
branch
3 times, most recently
from
ab6974e to
190a3e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix excessive memory consumption. I don't really think there's a memory leak, but the memory usage is extremely high, like 500mb+. At a certain point it starts getting released back to the OS which is a good sign, but GTK4 seems to use way more memory than it should on windows. One possible change that should be made is the windows that are stored in memory after they are closed maybe should be destroyed instead of hidden. Not sure if this would be better or worse.Use the windows file picker. The GTK file picker is a little buggy on windows and looks out of place so maybe switching to a windows one would be better.Fix notification actions. I can't get the notification actions to activate the app through the command line, so right now the notifications do nothing when clicked. Unsending notifications also doesn't work.Add CI for windows builds.