This repository was archived by the owner on Apr 28, 2025. It is now read-only.
use generic types for cy.then and cy.get aliases#260
Open
antonkri97 wants to merge 1 commit intoremix-run:mainfrom
Open
use generic types for cy.then and cy.get aliases#260antonkri97 wants to merge 1 commit intoremix-run:mainfrom
antonkri97 wants to merge 1 commit intoremix-run:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey all!
This is a small pr that, it seems to me, slightly improves the typing in Cypress when using aliases.
This is a move away from type assertion to a slightly more formal system.
This can help developers immediately see the format for working with aliases in their projects.
I was inspired by this cypress-io/cypress#8762 (comment).
This is how I made it work in my application.
https://github.com/antonkri97/family/pull/7/files#diff-ecc0256f03e3c2246926d3533817ed8df3416df522a4edee7b89a27a972d56a8
I moved all the aliases into a separate file. If you think it's a good idea, I could put these types in a separate place too.
Thanks :)