DESK-1692: Admin pages #1013

evanrbowers · 2026-01-07T00:10:00Z

Changes

…w in create menu

…dd registration code and product id.

# Conflicts: # frontend/src/models/products.ts # frontend/src/services/graphQLDeviceProducts.ts

aws-amplify-us-west-1 · 2026-01-07T00:14:36Z

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1013.d20k671nqqv4kl.amplifyapp.com

JamieRuderman · 2026-01-07T17:13:25Z

@codex can you assist with review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ad9c8e96a9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-01-07T17:18:32Z

frontend/src/pages/AdminPartnersPage/AdminPartnerDetailPanel.tsx

+    setLoading(true)
+    const result = await graphQLAdminPartner(partnerId)
+    if (result !== 'ERROR' && result?.data?.data?.admin?.partners?.[0]) {
+      setPartner(result.data.data.admin.partners[0])
+    }


Clear stale partner when admin lookup fails

If graphQLAdminPartner returns ERROR or no partner for a new partnerId, partner is left unchanged, so navigating from a valid partner to an invalid/deleted ID keeps showing the previous partner and the “Partner not found” branch never triggers. Consider setting partner to null when starting the fetch or when no results are returned to avoid stale data.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-01-07T17:18:32Z

frontend/src/pages/AdminUsersPage/AdminUserDetailPage.tsx

+    setLoading(true)
+    const result = await graphQLAdminUser(userId)
+    if (result !== 'ERROR' && result?.data?.data?.admin?.users?.items?.[0]) {
+      setUser(result.data.data.admin.users.items[0])
+    }


Clear stale user when admin lookup fails

If the admin user lookup fails or returns no items, user is never cleared, so switching from a valid user to an invalid/deleted ID keeps rendering the previous user and skips the “User not found” state. Resetting user to null on fetch start or when no results are returned prevents showing stale details.

Useful? React with 👍 / 👎.

JamieRuderman

It's nice an cleanly implemented - I just have some comments. Let me know if you wanna discuss. Thanks!

JamieRuderman · 2026-01-07T17:20:17Z

frontend/src/components/AdminSidebarNav.tsx

+const useStyles = makeStyles(({ palette }) => ({
+  list: {
+    position: 'static',
+    '& .MuiListItemIcon-root': { color: palette.grayDark.main },
+    '& .MuiListItemText-primary': { color: palette.grayDarkest.main },
+    '& .MuiListItemButton-root:hover .MuiListItemText-primary': { color: palette.black.main },
+    '& .Mui-selected, & .Mui-selected:hover': {
+      backgroundColor: palette.primaryLighter.main,
+      '& .MuiListItemIcon-root': { color: palette.grayDarker.main },
+      '& .MuiListItemText-primary': { color: palette.black.main, fontWeight: 500 },
+    },
+  },
+}))


This is the old way we were styling, trying to convert to the sx prop styles for all future work. With AI now might be simple to convert all.

JamieRuderman · 2026-01-07T17:28:55Z

frontend/src/pages/AdminPartnersPage/AdminPartnerDetailPanel.tsx

+  const handleBack = () => {
+    history.push('/admin/partners')
+  }


Back buttons maybe should use "useMobileBack" hook?

JamieRuderman · 2026-01-07T19:31:58Z

frontend/src/pages/AdminPartnersPage/AdminPartnerDetailPanel.tsx

+
+  const fetchPartner = async () => {
+    setLoading(true)
+    const result = await graphQLAdminPartner(partnerId)


I would usually create a model class for something like Partner I understand if you think not worth it for an internal tool.

JamieRuderman · 2026-01-07T19:41:49Z

frontend/src/pages/AdminUsersPage/AdminUsersListPage.tsx

+      header={
+        <Gutters>
+            <Stack direction="row" spacing={1} alignItems="center">
+              <IconButton


We should have the hamburger menu here too... really I'm not sure removing the normal header is a good idea, but i guess dosen't matter too much for internal tool, but you can't get out of admin mode on mobile currently.

put the normal header on admin pages

JamieRuderman · 2026-01-07T19:47:46Z

frontend/src/pages/AdminUsersPage/AdminUsersWithDetailPage.tsx

+  const maxPanels = layout.singlePanel ? 1 : (containerWidth >= THREE_PANEL_WIDTH ? 3 : 2)
+
+  useEffect(() => {
+    const updateWidth = () => {
+      if (containerRef.current) {
+        setContainerWidth(containerRef.current.offsetWidth)
+      }
+    }
+
+    updateWidth()
+
+    const resizeObserver = new ResizeObserver(updateWidth)
+    if (containerRef.current) {
+      resizeObserver.observe(containerRef.current)
+    }
+
+    return () => resizeObserver.disconnect()
+  }, [])
+
+  const onLeftMove = useCallback((event: MouseEvent) => {
+    const fullWidth = containerRef.current?.offsetWidth || 1000
+    leftHandleRef.current += event.clientX - leftMoveRef.current
+    leftMoveRef.current = event.clientX
+    if (leftHandleRef.current > MIN_WIDTH && leftHandleRef.current < fullWidth - MIN_WIDTH - rightWidth) {
+      setLeftWidth(leftHandleRef.current)
+    }
+  }, [rightWidth])
+
+  const onLeftUp = useCallback((event: MouseEvent) => {
+    setLeftGrab(false)
+    event.preventDefault()
+    window.removeEventListener('mousemove', onLeftMove)
+    window.removeEventListener('mouseup', onLeftUp)
+  }, [onLeftMove])
+
+  const onLeftDown = (event: React.MouseEvent) => {
+    setLeftGrab(true)
+    leftMoveRef.current = event.clientX
+    leftHandleRef.current = leftPrimaryRef.current?.offsetWidth || leftWidth
+    event.preventDefault()
+    window.addEventListener('mousemove', onLeftMove)
+    window.addEventListener('mouseup', onLeftUp)
+  }
+
+  const onRightMove = useCallback((event: MouseEvent) => {
+    const fullWidth = containerRef.current?.offsetWidth || 1000
+    rightHandleRef.current -= event.clientX - rightMoveRef.current
+    rightMoveRef.current = event.clientX
+    if (rightHandleRef.current > MIN_WIDTH && rightHandleRef.current < fullWidth - MIN_WIDTH - leftWidth) {
+      setRightWidth(rightHandleRef.current)
+    }
+  }, [leftWidth])


Seems like the panel width stuff is duplicated here - we would want to re-use the existing logic I would think.

JamieRuderman · 2026-01-07T19:51:39Z

frontend/src/components/AvatarMenu.tsx

          badge={licenseIndicator}
          onClick={handleClose}
        />
+        {adminMode ? (


I'm not sure we need a new boolean to track admin mode since we already have TestUI mode. We could rename testUI mode to admin mode and trigger that menu's visibility from the admin attribute on the user. And then just always show the admin menu items... maybe under the "more" menu? Having it integrated instead of separated? Maybe there is a reason to do it how you have it. This just seems simpler.

I'd pref to keep it as its own pages and not nested. It also does not fit well into the multi account of the main page.

evanrbowers added 17 commits December 10, 2025 23:29

feat: add device product page

cac1cbd

feat: add cloud sync for products

83c1770

feat: match scripting and device page layout

bfd5928

feat: updated product list page

5152e4e

fix: fix lock

5d6c96a

feat: support multiple accounts for products

008419d

feat: remove attributes hidden and scope

4f6ae7f

feat: show icons for platform types and limit what platform types sho…

4642f6d

…w in create menu

feat: update for create product slide out instead of new page

e23b7cd

feat: update product details to look like device details

7403454

feat: add back button

77a7e09

feat: add multi panel design

4941235

fix: fix thresholds

cb68cd5

feat: adjust sizing, add memory to orgs for selection/not selected, a…

e42d51a

…dd registration code and product id.

feat: auto refresh and add refresh button

c3353ff

feat: DESK-1692 Add admin pages

9ffab95

Merge branch 'main' into admin-pages

ad9c8e9

# Conflicts: # frontend/src/models/products.ts # frontend/src/services/graphQLDeviceProducts.ts

evanrbowers requested a review from JamieRuderman January 7, 2026 00:10

chatgpt-codex-connector bot reviewed Jan 7, 2026

View reviewed changes

JamieRuderman approved these changes Jan 7, 2026

View reviewed changes

evanrbowers added 4 commits January 13, 2026 17:28

incorporate pr changes and add updates for partner entity

3f7a481

Merge branch 'main' into admin-pages

9fcad8e

feat: updates to admin pages for use and caching

a63cb9b

feat: clean issues with partner entities

5993725

DESK-1692: Admin pages #1013

Are you sure you want to change the base?

DESK-1692: Admin pages #1013

Uh oh!

Conversation

evanrbowers commented Jan 7, 2026

Changes

Uh oh!

aws-amplify-us-west-1 bot commented Jan 7, 2026

Uh oh!

JamieRuderman commented Jan 7, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JamieRuderman left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants