-
Notifications
You must be signed in to change notification settings - Fork 9
Metal: Implement query pools #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7e50fc4 to
a6a0f2e
Compare
dcvz
reviewed
Aug 4, 2025
ce41069 to
c91f3c1
Compare
Contributor
Author
|
Rebased on latest main. |
DarioSamo
reviewed
Aug 5, 2025
c91f3c1 to
b031e80
Compare
DarioSamo
reviewed
Aug 5, 2025
DarioSamo
reviewed
Aug 5, 2025
DarioSamo
approved these changes
Aug 5, 2025
Contributor
|
Gonna wait on an approval from @dcvz to make sure this works as intended first. |
Contributor
|
Needs a rebase. |
d0f25c0 to
132dbff
Compare
Contributor
Author
|
Rebased |
dcvz
reviewed
Aug 6, 2025
95c7456 to
38609c9
Compare
38609c9 to
4b09c52
Compare
dcvz
approved these changes
Aug 6, 2025
DarioSamo
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements timestamp query pools for Metal using counter sample buffers.
sampleCountersInBufferin the active encoder.sampleCountersInBuffer.I've checked this with UnleashedRecomp and both the dependency graph and timestamps look similar to what I get from MoltenVK on an Apple GPU.
EDIT: Fixes #8.