Track Cargo.lock for reproducible builds#60
Merged
rendro merged 1 commit intorendro:mainfrom Mar 30, 2026
Merged
Conversation
Cargo recommends committing the lock file for binary/application crates to ensure reproducible builds. This is especially important for downstream packagers (e.g. Nix) who need deterministic dependency resolution without network access during builds.
Contributor
Author
|
This is now part of pinpox/opencrow#37 and avoids us having to pull in 7000 lines of Cargo.lock by default. |
Owner
|
Thanks @Mic92 for submitting this PR, and for integrating sediment in opencrow. Let me know if you're interested in further collaboration on AI memory layers |
Contributor
Author
It works well so far. I don't have any metrics or benchmarks. |
Mic92
added a commit
to pinpox/opencrow
that referenced
this pull request
Apr 12, 2026
Switch back to upstream rendro/sediment now that the Cargo.lock PR (rendro/sediment#60) has been merged and a tagged release is available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cargo recommends committing the lock file for binary/application crates to ensure reproducible builds.
This is especially important for downstream packagers (e.g. Nix) who need deterministic dependency resolution without network access during builds. Without a committed Cargo.lock, packagers must maintain their own copy, which can drift from what upstream tests against.