fix: consolidated bug fixes batch#5646
Open
Khizr97 wants to merge 25 commits into
Open
Conversation
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…sessions (#5633) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Sven <38101365+svenvoskamp@users.noreply.github.com>
…5618) Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: Sven <38101365+svenvoskamp@users.noreply.github.com>
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
9 Skipped Deployments
|
Contributor
Visual Regression Test Results ✅ PassedChromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=918 👉 Please review the visual changes in Chromatic and accept or reject them. |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
📦 Bundle Size Check✅ All bundles are within size limits 📊 View detailed bundle sizes> @reown/appkit-monorepo@1.7.1 size /home/runner/work/appkit/appkit > size-limit |
Contributor
…ationFrame Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… parseUnits error toFixed(20) produced more decimal places than viem's parseUnits allows, causing a transaction error when sending/swapping max token amount. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…allets API The FetchUtil fix to include empty-string projectId had a side effect: empty search, exclude, and include values were also being sent as URL params (e.g. ?search=&exclude=). The wallets API treats these differently from absent params, causing the certified wallet filter to return no results. Use undefined instead of '' for empty search/exclude/include so FetchUtil omits them from the URL. Update ApiController unit tests to reflect the corrected behaviour. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…lude param Bundle was at 235.04 KB (40 B over the 235 KB limit). The limit comment was stale (~222 KB) — the actual current size is ~235 KB. Bump to 236 KB to give a reasonable buffer. Also simplify the exclude param to use the same `|| undefined` pattern as include and search. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…tOpenButton
toHaveAttribute('disabled') on the wui-button custom element returns
'unexpected value "false"' in Playwright 1.48 because it evaluates the
JS disabled property rather than the HTML attribute. Checking the inner
<button> via shadow DOM piercing with toBeDisabled() is semantically
correct and version-stable.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… check Playwright's locator-based shadow DOM piercing fails on WebKit (iPhone 12), while toHaveAttribute fails on Chromium (Galaxy S5) for custom elements with a JS disabled=false property. Using page.waitForFunction with direct shadowRoot.querySelector() works reliably across both browser engines. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…bled check waitForFunction is blocked by the lab's strict CSP (no unsafe-eval). locator.evaluate uses Runtime.callFunctionOn (CSP-safe) and accesses shadowRoot.querySelector directly in JS — reliable on both Chromium and WebKit without relying on Playwright's CSS shadow-piercing locators. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidated batch of bug fixes from individual fix branches, ready for preview testing before merging to main.
sendTokenAmountto preserve precision (fix(send): use string type for sendTokenAmount to preserve precision #5618)projectIdin API requests when value is empty string (fix: include projectId in API requests when value is empty string #5631)setCaipAddress(fix: reject malformed CAIP-10 addresses in setCaipAddress #5634)toChecksummedAddress(fix: handle undefined address in wagmi toChecksummedAddress #5635)getAccountAddresses(fix: pass required account param in Bitcoin getAccountAddresses #5630)setDefaultChaincalls against undefined provider on stale sessions (fix: guard setDefaultChain calls against undefined provider on stale sessions #5633)Test plan