fix(wallet): bundle @walletconnect/logger to fix SSR named export error#5664
Open
Khizr97 wants to merge 1 commit into
Open
fix(wallet): bundle @walletconnect/logger to fix SSR named export error#5664Khizr97 wants to merge 1 commit into
Khizr97 wants to merge 1 commit into
Conversation
Adds a vite library build step to @reown/appkit-wallet so @walletconnect/logger is inlined into the dist output. Previously the tsc-only build left it as a runtime import; Vite SSR (SvelteKit, Next.js) would externalize it and Node.js would resolve the CJS version, causing "Named export not found" errors on Vercel. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
9 Skipped Deployments
|
🦋 Changeset detectedLatest commit: fd8434d The changes in this PR will be included in the next version bump. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@reown/appkit-walletpreviously usedtsc --buildonly, which left@walletconnect/loggeras a raw runtime import indist/esm/SyntaxError: Named export 'generateChildLogger' not foundon Vercel and similar SSR environments@walletconnect/loggerwas bumped from2.1.2→3.0.0(which added anexportsmap that changed how Vite handles SSR bundling)@walletconnect/loggerinto the dist output — same pattern as@reown/appkit-cdnTest plan
@walletconnect/loggerimport no longer present anywhere indist/esm/after builddist/esm/exports/index.jssucceeds without CJS/ESM error (simulates Vercel SSR runtime)Closes REOWN-4396
🤖 Generated with Claude Code