use GHCR mirror for cog-base images in integration tests#2866
Open
markphelps wants to merge 1 commit intomirror-cog-base-workflowfrom
Open
use GHCR mirror for cog-base images in integration tests#2866markphelps wants to merge 1 commit intomirror-cog-base-workflowfrom
markphelps wants to merge 1 commit intomirror-cog-base-workflowfrom
Conversation
markphelps
changed the title
Set COG_REGISTRY_HOST=ghcr.io/replicate/cog in CI so integration tests resolve cog-base images from GHCR instead of r8.im. CI changes: - Set COG_REGISTRY_HOST in the integration test job env Harness changes: - Add COG_REGISTRY_HOST to propagatedEnvVars so cog serve inherits it Test simplification: - 5 tests no longer need per-test registries since they can resolve cog-base images from the GHCR mirror via COG_REGISTRY_HOST: build_base_image_sha, build_cog_version_match, build_python313_base_image, torch_cuda_baseimage, torch_baseimage_fallback
markphelps
force-pushed
the
registry-tests
branch
from
2deb948 to
83c792c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update CI and integration tests to resolve cog-base images from GHCR instead of r8.im.
Depends on: #2871 (mirror workflow) being merged and run first to populate GHCR.
Changes
.github/workflows/ci.yamlCOG_REGISTRY_HOST=ghcr.io/replicate/cogin integration test envintegration-tests/harness/harness.goCOG_REGISTRY_HOSTtopropagatedEnvVarssocog serveinherits it.txtartest filesregistry-start/registry-seed/env COG_REGISTRY_HOSTboilerplate from tests that can use the shared GHCR mirrorHow it works
CI sets
COG_REGISTRY_HOST=ghcr.io/replicate/cog, so allcog buildcommands resolve base images fromghcr.io/replicate/cog/cog-base:<tag>instead ofr8.im/cog-base:<tag>.cog-base:python3.12etc. from GHCRcog-base:cuda12.4-python3.12-torch2.5.1etc. from GHCRregistry-start(3): push to their own per-test registry, unaffected5 tests that previously started per-test registries and seeded fake cog-base images now use the GHCR mirror directly:
build_base_image_sha.txtarbuild_cog_version_match.txtarbuild_python313_base_image.txtartorch_cuda_baseimage.txtartorch_baseimage_fallback.txtar