Refactor slot response streaming messages

[markphelps]

Summary

• Rename slot response log and output messages to explicit streaming-oriented variants.
• Add protocol version and binary chunk variants for future transport extensions.
• Include output chunk indexes and update parent/worker routing tests.

Test Plan

• mise run fmt:rust:fix
• mise run lint:rust
• mise run test:rust

[markphelps]

/bonk review

[ask-bonk]

@markphelps Bonk workflow was cancelled.

View workflow run · To retry, trigger Bonk again.

[ask-bonk]

Based on my review of the code changes in PR #3017, here's my assessment:

Review Summary

LGTM - The PR refactors slot response streaming messages cleanly and adds extensibility for future transport protocols.

Key Changes

1. Renamed message variants for clarity:

   • Log → LogLine (explicit streaming-oriented name)
   • Output → OutputChunk (explicit streaming-oriented name)

2. Added protocol versioning with ProtocolVersion message and SLOT_RESPONSE_PROTOCOL_VERSION = 1 constant for future compatibility checking

3. Added BinaryChunk for future WebSocket streaming support (currently logged and ignored)

4. Added index: u64 to OutputChunk for output chunk ordering/tracking

5. Updated all call sites in orchestrator, worker, and tests to use new variant names

Code Quality

• Clean separation of concerns - protocol changes isolated to protocol.rs
• Backward-compatible approach using explicit protocol version
• Good test coverage for new variants
• Proper handling of unknown protocol versions (logs warning, continues)

Minor Observation

The index field in OutputChunk is received but not currently used in the orchestrator (marked with _). This appears to be intentional groundwork for future ordering/reassembly logic.

github run