This repository was archived by the owner on May 4, 2022. It is now read-only.
Conversation
Collaborator
|
Good work, this PRs short and easy to review! Promoting to |
Collaborator
|
unbooping: tests don't pass |
lhchavez
changed the title
lhchavez
force-pushed
the
lh-java-dap
branch
4 times, most recently
from
d7988e2 to
0763499
Compare
Collaborator
|
🚓 Looks like this PR has grown too powerful! Going to have to demote it... sorry frend |
This change bundles a pre-built binary of the Java DAP with microsoft/java-debug#379 and replit/java-debug@2a556e5 applied, so that we can specify what host/port it should bind to, in addition to always using localhost as the interface that it binds to. In order for this to function correctly, it also needs to be running a more recent version of the Java LSP, so we will upgrade that too.
Collaborator
|
prebooping: tests are pending |
dan-stowell
approved these changes
Jun 9, 2021
dan-stowell
left a comment
dan-stowell
left a comment
There was a problem hiding this comment.
Those while True loops scare me - what do people do if it gets stuck? I guess you just reconnect. Otherwise 👍
Collaborator
|
unbooping: approved |
Contributor
Author
yup, reconnect. the caller (the debugproxy) has a timeout that pulls the plug eventually. unfortunately the DAP is super flaky in the first few launches (and most of the search results for the error suggest "have you tried turning it off and on again"). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change bundles a pre-built binary of the Java DAP with
microsoft/java-debug#379 applied, so that we can
specify what port it should bind to.
In order for this to function correctly, it also needs to be running a
more recent version of the Java LSP, so we will upgrade that too.