Skip to content

fix(health): accept glob alias in health-rules and correct stale docs#463

Closed
RaghavChamadiya wants to merge 3 commits into
mainfrom
docs/alerting-v2-statuses
Closed

fix(health): accept glob alias in health-rules and correct stale docs#463
RaghavChamadiya wants to merge 3 commits into
mainfrom
docs/alerting-v2-statuses

Conversation

@RaghavChamadiya

Copy link
Copy Markdown
Member

What

Integrity sweep over the code-health configuration surface and docs. One behavior change, the rest documentation corrections.

Config fix

Both doc examples for .repowise/health-rules.json showed a "glob" key on rule entries, but the parser only accepted path / path_glob, so any per-path override copied from the docs was silently ignored. glob is now accepted as an alias (with a test), the examples use the canonical path key, and the aliases are documented.

Docs corrections

  • analysis/health/README.md claimed "twelve biomarkers"; the registry holds 26, plus 3 governance findings written by a separate additive pass.
  • docs/architecture/code-health.md was missing 6 of the biomarker files from the layer's file tree (low_cohesion, god_class, coverage_gradient, prior_defect, large_assertion_block, duplicated_assertion_block), and still listed "no PR-mode delta in v1" as a non-goal even though the change_risk package and repowise risk shipped.
  • docs/CODE_HEALTH.md described hotspot health as an average over "the top-25% hotspot files"; it actually averages over the files the git layer classifies as hotspots (churn percentile plus minimum-activity floors).

Tests

tests/unit/health/test_health_config.py gains an alias-acceptance test; the suite passes.

- config.py: accept "glob" (and keep "path_glob") as aliases for the
  canonical "path" key in .repowise/health-rules.json rules. Both doc
  examples showed "glob", which the parser silently ignored, so configs
  copied from the docs never applied; now they work, and the examples
  use the canonical key with the aliases documented. Test added.
- analysis/health/README.md: "twelve biomarkers" was stale; the registry
  holds 26, plus 3 additive governance findings.
- docs/architecture/code-health.md: add the 6 biomarker files missing
  from the layer file tree; drop the stale "no PR-mode delta in v1"
  non-goal (the change_risk package and repowise risk shipped).
- docs/CODE_HEALTH.md: hotspot health averages over files the git layer
  classifies as hotspots, not a fixed top-25% slice.

No behavior change other than the new key aliases.
Graph-aware scanning, function-level reachability (per-ecosystem coverage), VEX export, PCI-DSS and SOC 2 compliance reporting, signed Slack-compatible security webhooks, and the audit-event stream are now live on the hosted platform; matrix rows and section 5 prose updated to match.
Slack/Teams alerting now covers engineering signals (hotspot drift,
bus-factor risk, health decline, decision staleness) alongside security
events, and the engineering leader dashboard is GA on hosted (Teams).
@repowise-bot

repowise-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown

✅ Health: 7.6 (unchanged)
2 hotspots

⚠️ Change risk: moderate (riskier than 36% of this repo's commits · raw 7.8/10)
This change's risk is driven by:

  • large diff (many lines added)
  • scattered, high-entropy change
🔥 Hotspots touched (2)
  • .../health/config.py — 1 commits/90d, 5 dependents · primary owner: Raghav Chamadiya (100%)
  • .../health/test_health_config.py — 1 commits/90d, 0 dependents · primary owner: Raghav Chamadiya (100%)

📊 Full report · ⭐ Star Repowise · 📥 Install bot · Last updated 2026-06-12 08:28 UTC
Silence on a single PR with [skip repowise] in the title · Per-repo toggle on repowise.dev/settings?tab=bot

@RaghavChamadiya

Copy link
Copy Markdown
Member Author

Superseded: this exact changeset already landed on main inside #458 (its squash includes the glob-alias commit). All five files are byte-identical between this branch and main, so closing.

@RaghavChamadiya RaghavChamadiya deleted the docs/alerting-v2-statuses branch June 12, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant