Open
Conversation
Collaborator
mayaracsferreira
left a comment
There was a problem hiding this comment.
Taianne
Parabéns pela entrega!!!
Vc entregou o objetivo da entrega, tem pequenos ajustes a serem feitos mas são bem simples. Arrasou demais! continue assim vc vai longe!!
|
|
||
| def emprestar_livro(self, nome_livro): | ||
| for livro in self.livros: | ||
| if livro['nome'] == nome_livro: |
Collaborator
There was a problem hiding this comment.
Olá, Taianne
Massa demais que fez as lógicas propostas. Nessa linha tem um pequeno erro em livro['nome']
o seu livro já é um objeto livro por isso ele já tem as propriedades livro.nome e livro.esta_emprestado
|
|
||
|
|
||
|
|
||
| def test_exibir_livro_deve_passar(self): |
Collaborator
There was a problem hiding this comment.
A partir dessa linha o código não está indentado, acho que é por isso que o teste estava cinza ontem na apresentação e não executava. Vc pode usar os atalhos do VS code para formatar o arquivo ou ir no menu View > Command Palette > Format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Projeto passível de ajustes!