fix: include full stack traces in error logs#8006
Open
derekderie wants to merge 1 commit into
Open
Conversation
Author
|
Experienced a lot of trouble in debugging #7978, had to create this PR in order to successfully uncover the root cause of the wiki crashes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Error logs across all job handlers only logged
err.message, which drops the stack trace entirely. This makes it very hard to diagnose where errors originate.Fix
server/core/logger.js: addwinston.format.errors({ stack: true })to the format chain, and update the printf format to append the stack
when present.
server/jobs/*.js(8 files): pass the fullerrobject toWIKI.logger.error()instead oferr.message.