Skip to content

fix: include full stack traces in error logs#8006

Open
derekderie wants to merge 1 commit into
requarks:mainfrom
AConsultancyCompany:fix/improve-error-logging-with-stack-traces
Open

fix: include full stack traces in error logs#8006
derekderie wants to merge 1 commit into
requarks:mainfrom
AConsultancyCompany:fix/improve-error-logging-with-stack-traces

Conversation

@derekderie
Copy link
Copy Markdown

Problem

Error logs across all job handlers only logged err.message, which drops the stack trace entirely. This makes it very hard to diagnose where errors originate.

Fix

  • server/core/logger.js: add winston.format.errors({ stack: true })
    to the format chain, and update the printf format to append the stack
    when present.
  • server/jobs/*.js (8 files): pass the full err object to
    WIKI.logger.error() instead of err.message.

@auto-assign auto-assign Bot requested a review from NGPixel May 12, 2026 06:35
@derekderie
Copy link
Copy Markdown
Author

Experienced a lot of trouble in debugging #7978, had to create this PR in order to successfully uncover the root cause of the wiki crashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants