-
Notifications
You must be signed in to change notification settings - Fork 48
adds support for listener in secretsManager #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: initialization
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
WalkthroughThis pull request introduces event-driven subscription mechanisms throughout the secrets manager architecture. It adds abstract method definitions for storage and provider change callbacks in their respective abstract base classes, implements these methods in concrete classes (SecretsManagerEncryptedStorage and FileBasedProviderRegistry), and makes the EncryptedElectronStore's onChange method generic to support any value type. FileBasedProviderRegistry includes logic to synchronize in-memory provider state with storage changes and notify registered callbacks. SecretsManager exposes the new provider change subscription capability and adds a method to list provider configurations. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.