Refactor AppOptions and add larger-than-RAM feature flag
#12256
Merged
+210
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
📺 re_viewer
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
abey79
approved these changes
Jan 5, 2026
Member
abey79
left a comment
abey79
left a comment
There was a problem hiding this comment.
lgtm (though this minor snapshot change is odd)
Member
There was a problem hiding this comment.
The new snapshot has different highlight on the top right "show left panel" icon. Not sure why or if it even matters.
Member
Author
There was a problem hiding this comment.
Maybe it was below the threshold of error on main? 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only visible in debug builds.
I couldn't resist grouping all the video settings into its own struct. This unfortunately means the video settings will reset to default in the next Rerun release. But having a flat structure of everything just isn't scalable.
In order to be able to read the "larger-than-ram" setting in time, I also had to re-arrange the startup code for the viewer slightly.
Let's hold off merging until we cut the 0.28 release branch.