Skip to content

Conversation

@abey79
Copy link
Member

@abey79 abey79 commented Dec 18, 2025

Related

What

This PR introduces a set of test for query_dataset with various Query values. The actual test cases are currently limited to those which return ALL chunks from the test recording, because the OSS server currently ignores query. This PR is still valuable because:

  1. It tests that the schema is not affected by Some query (turned out it was, see sibling PR).
  2. It establishes a test framework that will be very useful when working on RR-2613

This PR also removes the Query.columns_always_include_chunk_ids field because it's pointless. Redap mandates that such column is always returned.

@abey79 abey79 added 🔨 testing testing and benchmarks exclude from changelog PRs with this won't show up in CHANGELOG.md labels Dec 18, 2025
@github-actions
Copy link

github-actions bot commented Dec 18, 2025

Web viewer built successfully.

Result Commit Link Manifest
4170b91 https://rerun.io/viewer/pr/12266 +nightly +main

View image diff on kitdiff.

Note: This comment is updated whenever you push a commit.

@abey79 abey79 marked this pull request as draft December 18, 2025 08:47
@abey79 abey79 marked this pull request as ready for review December 18, 2025 09:13
@abey79 abey79 changed the title Add test coverage for QueryDataset.query Add test coverage for QueryDatasetRequest.query Dec 18, 2025
@abey79 abey79 added the dataplatform Rerun Data Platform integration label Dec 18, 2025
@teh-cmc teh-cmc self-requested a review January 5, 2026 08:57
@abey79 abey79 merged commit 030ea41 into main Jan 5, 2026
43 of 44 checks passed
@abey79 abey79 deleted the antoine/fix-query-dataset branch January 5, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dataplatform Rerun Data Platform integration exclude from changelog PRs with this won't show up in CHANGELOG.md 🔨 testing testing and benchmarks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants