Skip to content

Conversation

@illusionalsagacity
Copy link
Contributor

I managed to find the source of this with Claude's help, though I don't have enough experience with ocaml to know for sure if this is an idiomatic fix.

resolves #8086

I managed to find the source of this with Claude's help, though I don't
have enough experience with ocaml to know for sure if this is an
idiomatic fix.

resolves rescript-lang#8086

Signed-off-by: Rob <illusionalsagacity@users.noreply.github.com>
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 12, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@8087

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@8087

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@8087

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@8087

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@8087

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@8087

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@8087

commit: c4bdcd4

@cknitt cknitt requested a review from cristianoc December 12, 2025 09:30
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to avoid quoting in the first place instead of un-quoting later?

@cknitt
Copy link
Member

cknitt commented Dec 25, 2025

@cristianoc Codex says:

Avoiding the un-quoting here would mean normalizing escaped identifiers earlier (likely when the parser/typedtree builds Ident.t for escaped names). That’s a broader change and could affect other compiler stages that might be relying on the escaped form. The current fix is a localized workaround in genType that keeps the normalization close to the emission logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v12 regression; gentype of record with escaped record fields generates invalid Typescript code

3 participants