Fix duplicate MessageId in EmailEventData breaking build#124
Merged
Conversation
PR #112 and #123 each added a message_id property to EmailEventData. Git merged both without a textual conflict, producing two properties named MessageId (CS0102) and breaking the build on main since #112 merged. Remove #112's duplicate (which also carried an inaccurate 'only set for EmailReceived' remark) and keep #123's, since the server sends message_id for both outbound and inbound email events.
dielduarte
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mainhas been failing to build since #112 merged (build: failureon the merge commit).EmailEventDatacontains twoMessageIdproperties →error CS0102: the type 'EmailEventData' already contains a definition for 'MessageId'.Root cause
Two separately-merged PRs each added a
message_idproperty toEmailEventData:MessageIdnear the top of the class.MessageIdagain in its inbound block.The insertions were at different line ranges, so git merged both with no textual conflict — but the result is a semantically invalid class with a duplicate member. #112's PR CI was green in isolation; the post-merge CI run on
mainwent red and wasn't caught.Fix
Remove #112's duplicate, keep #123's. #123's is in the correct common position with an accurate summary; #112's also carried a misleading
Only set for EmailReceivedremark (the server sendsmessage_idfor outbound events too), so dropping it fixes an inaccuracy as well.Verification
Local build + full test suite on .NET 8 (matching CI): build succeeds, 122/122 tests pass.
Summary by cubic
Fixes a build failure by removing the duplicate MessageId property from EmailEventData. Keeps the canonical property and removes the incorrect “only set for EmailReceived” remark, since the server sends message_id for both inbound and outbound events.
Written for commit 0fca7ab. Summary will update on new commits.