fix: encode contact email path identifiers#234
Open
mayankbohradev wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
===========================================
+ Coverage 82.66% 95.79% +13.12%
===========================================
Files 4 58 +54
Lines 75 3137 +3062
===========================================
+ Hits 62 3005 +2943
- Misses 13 132 +119 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Testing
Note
EntryPointshas no.get). CI runs lint on Python 3.8-3.11 per the workflow.Summary by cubic
URL-encodes contact email identifiers in API paths to prevent mis-parsing when emails contain reserved characters. Applies to
Contacts,Contacts.Segments, andContacts.Topicsin both sync and async methods.urllib.parse.quote(safe="")across update/get/remove, segments add/remove/list, and topics list/update.Written for commit fe234f0. Summary will update on new commits.