Polars pp analysis #84
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function tested in the test suite demonstrates it is ~30% faster than the previous pandas implementation. This function is called many times in `pre_post_pp_analysis_with_reversal_and_bootstrapping` so performance improvement should be significant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates from pandas to polars for the Pre-Post analysis.
The speed improvements are as follows...
Overall Speed Improvements Reviewing GH Actions Times
A measure of the speed improvement is evident in the time the GitHub Actions take to run; this PR reduces the time taken by ~20%, reducing the old time taken of ~17.5 minutes down to ~14 minutes. Looking at the GitHub Action named
teststhat is run with python 3.13, this PR is ~25% faster.Benchmark Results in the Test Suite
Benchmarking of the
_pre_post_pp_analysis_with_reversalfunctions (both pandas and polars) is added to the test suite in this PR. The result when running this locally is ~35% faster than the previous pandas code.Summary: Polars implementation is ~35% faster than pandas (median: 74.01ms vs 100.08ms)