fix: Test cases and refactor #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
priyanshshah2442
commented
Mar 6, 2025
priyanshshah2442
commented
- Fixes
- Refactor Code
- Setup Test Case Environment
- Test Cases
priyanshshah2442
force-pushed
the
test_cases_and_refactor
branch
from
367003f to
a901f02
Compare
vorasmit
reviewed
Mar 11, 2025
vorasmit
reviewed
Mar 11, 2025
vorasmit
reviewed
Mar 11, 2025
vorasmit
reviewed
Mar 11, 2025
Comment on lines
50
to
54
| # if setting.processing_time > time_now(): | ||
| # continue | ||
|
|
||
| if setting.last_execution and getdate(setting.last_execution) == getdate(): | ||
| continue | ||
| # if setting.last_execution and getdate(setting.last_execution) == getdate(): | ||
| # continue |
vorasmit
reviewed
Mar 11, 2025
priyanshshah2442
force-pushed
the
test_cases_and_refactor
branch
3 times, most recently
from
0c4d78a to
694e5ad
Compare
priyanshshah2442
force-pushed
the
test_cases_and_refactor
branch
from
694e5ad to
bfbc981
Compare
priyanshshah2442
force-pushed
the
test_cases_and_refactor
branch
from
26bfa86 to
0f9a89e
Compare
Abdeali099
reviewed
Apr 22, 2025
|
|
||
| for setting in auto_pay_settings: | ||
| if not setting.auto_generate_entries: | ||
| frappe.throw(_("Auto Generate Entries is not enabled")) |
Member
There was a problem hiding this comment.
Why throwing an error?
I think this not required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.