Skip to content

docs: CLAUDE.md proposals for 5 repos (step-function-workflow-orchestrator, identity-graph, dos-data-pipeline, resonate-utils, batch-expression-modeling)#5

Open
shrivastavakapil2000 wants to merge 1 commit into
mainfrom
claude/serene-davinci-AzBil
Open

Conversation

@shrivastavakapil2000

Copy link
Copy Markdown

Summary

This PR contains CLAUDE.md file proposals for 5 repositories that had PRs recently merged to main by members of the team (SayaliPat, shrivastavakapil2000, JoeVsVolcano, mike-brant, nathan-resonate).

Because the Claude Code session running this automation is scoped only to resonate/.github, the CLAUDE.md files are staged here as proposals under claude-md-proposals/<repo-name>/CLAUDE.md. Each file should be copied into the root of its respective repository as CLAUDE.md and a PR opened there.


Repos & Files

File in this PR Target Repo Status
claude-md-proposals/step-function-workflow-orchestrator/CLAUDE.md resonate/step-function-workflow-orchestrator 🆕 New
claude-md-proposals/identity-graph/CLAUDE.md resonate/identity-graph 🆕 New
claude-md-proposals/dos-data-pipeline/CLAUDE.md resonate/dos-data-pipeline 🆕 New
claude-md-proposals/resonate-utils/CLAUDE.md resonate/resonate-utils 🆕 New
claude-md-proposals/batch-expression-modeling/CLAUDE.md resonate/batch-expression-modeling 🔄 Updated

What's Captured in Each File

step-function-workflow-orchestrator

  • Full pipeline catalogue with EMR versions
  • EMR 5→7 migration steps (CDP-118269)
  • Integration test harness pattern (conftest.py, synthetic golden datasets, pytest fixtures)
  • check-source-freshness Lambda strategies
  • dynamic-dates Lambda token reference
  • QA environment configuration
  • GHA deploy workflow instructions (critical --ref flag warning)

identity-graph

  • 11-job catalogue with purpose of each job
  • Key correctness invariants discovered during code review (null guards, deterministic tie-breakers)
  • Shared utilities: HashUtils, StagingWriter, AddressNormalizer, IpFilter, ScoringConfig
  • JDK 17 --add-opens flags requirement
  • Scopt CLI args pattern (not application.conf)

dos-data-pipeline

  • DistrictResolver: L2_CONFIRMED/L2_UNCONFIRMED/IP_INFERRED/null classification
  • l2_party_confirmed field semantics
  • 4-file zip→district mapping convention
  • ToBitmap L2-confirmed marker bit (200299998) and wipe range
  • Coordinated deploy requirement for Units 3/4/5

resonate-utils

  • Playwright Locator vs ElementHandle pattern (key fix from PR #25)
  • LiveRamp resend retry logic with Pendo blocking workaround
  • ECS CloudWatch log path

batch-expression-modeling (updated from existing CLAUDE.md)

Added sections covering:

  • Formatter output partition order change: vendor=*/method=*/ (CDP-118857)
  • Metrics lambda (batch-delivery-formatter-publish-metrics) and InfluxDB measurements
  • File extension hardcoding (.csv.gz) in publisher lambdas (CDP-118953/955)
  • delta_with_full_fallback refresh type fix
  • Prior-stitch partition pruning (prunePartitions with Seq[String])
  • Batch-stitch AddJobFlowSteps staggering via index-based Wait (CDP-118972)
  • New Batch Delivery Formatter Metrics Lambda deployment type in bem-lambdas.yml

Next Steps

To apply these to the actual repos, for each file:

# Example for step-function-workflow-orchestrator
cp claude-md-proposals/step-function-workflow-orchestrator/CLAUDE.md /path/to/step-function-workflow-orchestrator/CLAUDE.md
cd /path/to/step-function-workflow-orchestrator
git checkout -b docs/add-claude-md
git add CLAUDE.md
git commit -m "docs: add CLAUDE.md"
git push -u origin docs/add-claude-md
gh pr create --title "docs: add CLAUDE.md" --body "Adds CLAUDE.md guidance for Claude Code in this repo."

https://claude.ai/code/session_012jmYLE5WsWE6p9mJRBWNKn


Generated by Claude Code

Adds CLAUDE.md files for 5 repositories with PRs merged to main by:
SayaliPat, shrivastavakapil2000, JoeVsVolcano, mike-brant, nathan-resonate

Repos covered:
- step-function-workflow-orchestrator (162+ merged PRs from team)
- identity-graph (SayaliPat: person-identity-graph port, 443 unit tests)
- dos-data-pipeline (mike-brant: DistrictResolver, l2_party_confirmed, ToBitmap)
- resonate-utils (SayaliPat: LiveRamp Playwright automation fixes)
- batch-expression-modeling (update: CDP-118857/972 formatter+stitch changes)

Each CLAUDE.md captures: project overview, tech stack, repo structure,
common dev tasks, key invariants, and gotchas discovered in recent PRs.

https://claude.ai/code/session_012jmYLE5WsWE6p9mJRBWNKn
Copilot AI review requested due to automatic review settings June 2, 2026 13:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds proposed CLAUDE.md guidance files (staged under claude-md-proposals/<repo>/CLAUDE.md) intended to be copied into the root of five separate Resonate repositories to guide Claude Code usage and repository-specific development workflows.

Changes:

  • Added new CLAUDE.md proposals for: step-function-workflow-orchestrator, identity-graph, dos-data-pipeline, and resonate-utils.
  • Updated the existing CLAUDE.md proposal for batch-expression-modeling with additional operational/deployment and Step Functions (JSONata) guidance.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
claude-md-proposals/step-function-workflow-orchestrator/CLAUDE.md Adds orchestrator repo guidance: structure, integration tests, deploy workflow usage, pipeline catalogue, and operational constraints.
claude-md-proposals/identity-graph/CLAUDE.md Adds identity-graph repo guidance: job catalogue, key invariants, shared utilities, build/test/deploy notes.
claude-md-proposals/dos-data-pipeline/CLAUDE.md Adds DOS pipeline guidance: DistrictResolver semantics, ToBitmap marker bit notes, coordinated deploy requirements, test guidance.
claude-md-proposals/resonate-utils/CLAUDE.md Adds resonate-utils guidance: repo layout, Playwright Locator guidance for LiveRamp automation, testing and operational notes.
claude-md-proposals/batch-expression-modeling/CLAUDE.md Updates BEM guidance with expanded architecture, deploy workflow notes, formatter/stitch changes, and JSONPath→JSONata conversion reference.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants