Skip to content

Conversation

@danneu
Copy link

@danneu danneu commented Jun 10, 2016

I was passing through and noticed that the koa example was severely out of date, so I cleaned it up and made it much more koa-idiomatic.

Mainly,

  • Removed redundant try/catch error handlers since koa already lifts uncaught errors into 500 responses.
  • Flattened the boot procedure
  • Ensured that the RethinkDB connection always closes even if downstream handlers fail.

@danneu danneu mentioned this pull request Jun 10, 2016
@danielmewes
Copy link
Member

Thanks for the PR @danneu !

@segphault or @deontologician is one of you available for reviewing this change?

@deontologician
Copy link
Contributor

I will leave it to segphault, I haven't ever used koa myself

@segphault segphault removed their assignment Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants