Skip to content

evals: add suite label to loki eval tasks#129

Merged
slashpai merged 1 commit into
rhobs:mainfrom
slashpai:update-evals-label
Jun 17, 2026
Merged

evals: add suite label to loki eval tasks#129
slashpai merged 1 commit into
rhobs:mainfrom
slashpai:update-evals-label

Conversation

@slashpai

Copy link
Copy Markdown
Member

Signed-off-by: Jayapriya Pai <janantha@redhat.com>
@slashpai slashpai requested a review from a team June 17, 2026 12:10
@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 552baf60-15b2-47f2-9403-59fb5ae91f0d

📥 Commits

Reviewing files that changed from the base of the PR and between c79eede and 0495a95.

📒 Files selected for processing (4)
  • evals/mcpchecker/tasks/logs/loki-label-names.yaml
  • evals/mcpchecker/tasks/logs/loki-label-values.yaml
  • evals/mcpchecker/tasks/logs/loki-list-instances.yaml
  • evals/mcpchecker/tasks/logs/loki-query-network-flows.yaml

📝 Walkthrough

Walkthrough

Four Loki evaluation task YAML files under evals/mcpchecker/tasks/logs/ (loki-label-names.yaml, loki-label-values.yaml, loki-list-instances.yaml, loki-query-network-flows.yaml) each receive one new line: suite: observability added to their labels metadata block. No other fields, prompt text, verification criteria, or task logic are changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding a suite label to loki evaluation tasks across multiple YAML files.
Description check ✅ Passed The description references a related pull request in another repository, which is relevant context for understanding the changeset's purpose and context.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@andreasgerstmayr

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci

openshift-ci Bot commented Jun 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreasgerstmayr, slashpai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [andreasgerstmayr,slashpai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@slashpai slashpai merged commit c7ebbd2 into rhobs:main Jun 17, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants