Skip to content

feat: fork bcryptjs as @opensourceframework/bcryptjs#110

Open
riceharvest wants to merge 3 commits intomainfrom
fix/issue-108
Open

feat: fork bcryptjs as @opensourceframework/bcryptjs#110
riceharvest wants to merge 3 commits intomainfrom
fix/issue-108

Conversation

@riceharvest
Copy link
Copy Markdown
Owner

Forks the unmaintained bcryptjs package into @opensourceframework/bcryptjs to provide a maintained drop-in replacement.## Changes

  • Adds new package under packages/bcryptjs
  • Preserves original API
  • Includes minimal smoke test

Testing: node test/bcrypt.test.js – hashing works.

Fixes #108

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@qodo-code-review
Copy link
Copy Markdown

CI Feedback 🧐

A test triggered by this PR failed. Here is an AI-generated analysis of the failure:

Action: bundle-size

Failed stage: Build packages [❌]

Failed test name: ""

Failure summary:

The action failed during the build step pnpm turbo run build --filter="./packages/**"
--cache-dir=".turbo" because Turborepo could not parse the repo’s Turbo configuration file.
-
Turborepo raised turbo_json_parse_error and exited with code 1.
- The config contains an unknown key
tasks (error points to around line 5: "tasks": { ... }), which is not valid for the installed
Turborepo version/config format (expects pipeline instead of tasks).
- After the failure, the runner
also reported fatal: No url found for submodule path </code>pospos2<code> in .gitmodules during cleanup, but
this occurred post-failure and did not cause the main job to fail.

Relevant error logs:
1:  ##[group]Runner Image Provisioner
2:  Hosted Compute Agent
...

219:  shell: /usr/bin/bash -e {0}
220:  env:
221:  PNPM_HOME: /home/runner/setup-pnpm/node_modules/.bin
222:  ##[endgroup]
223:  Scope: all 34 workspace projects
224:  Lockfile is up to date, resolution step is skipped
225:  Progress: resolved 1, reused 0, downloaded 0, added 0
226:  Packages: +2398
227:  ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
228:  Progress: resolved 2398, reused 722, downloaded 0, added 0
229:  Progress: resolved 2398, reused 2311, downloaded 0, added 36
230:  Progress: resolved 2398, reused 2311, downloaded 0, added 262
231:  Progress: resolved 2398, reused 2311, downloaded 0, added 1460
232:  Progress: resolved 2398, reused 2311, downloaded 0, added 2338
233:  Progress: resolved 2398, reused 2311, downloaded 0, added 2398, done
234:  WARN  Failed to create bin at /home/runner/work/opensourceframework/opensourceframework/node_modules/.bin/docs-bot. ENOENT: no such file or directory, open '/home/runner/work/opensourceframework/opensourceframework/node_modules/@opensourceframework/docs-bot/dist/index.js'
235:  dependencies:
...

245:  + eslint 10.0.3
246:  + eslint-config-prettier 10.1.8
247:  + eslint-plugin-jest 29.15.0
248:  + globals 17.4.0
249:  + husky 9.1.7
250:  + lint-staged 16.3.3
251:  + prettier 3.8.1
252:  + turbo 2.8.15
253:  + typescript 5.9.3
254:  + typescript-eslint 8.57.0
255:  + vitest 2.1.9
256:  packages/next-mdx prepare$ tsup
257:  packages/next-seo prepare$ husky
258:  packages/next-seo prepare: .git can't be found
259:  packages/next-seo prepare: Done
260:  WARN  Failed to create bin at /home/runner/work/opensourceframework/opensourceframework/node_modules/.bin/docs-bot. ENOENT: no such file or directory, open '/home/runner/work/opensourceframework/opensourceframework/node_modules/@opensourceframework/docs-bot/dist/index.js'
261:  packages/next-mdx prepare: �[34mCLI�[39m Building entry: src/client.ts, src/server.ts
...

304:  packages/next-mdx prepare: �[32mDTS�[39m �[1mdist/client.d.mts �[22m�[32m859.00 B�[39m
305:  packages/next-mdx prepare: �[32mDTS�[39m �[1mdist/server.d.mts �[22m�[32m2.61 KB�[39m
306:  packages/next-mdx prepare: Done
307:  Done in 13.9s using pnpm v9.15.9
308:  ##[group]Run pnpm turbo run build --filter="./packages/**" --cache-dir=".turbo"
309:  �[36;1mpnpm turbo run build --filter="./packages/**" --cache-dir=".turbo"�[0m
310:  shell: /usr/bin/bash -e {0}
311:  env:
312:  PNPM_HOME: /home/runner/setup-pnpm/node_modules/.bin
313:  ##[endgroup]
314:  Attention:
315:  Turborepo now collects completely anonymous telemetry regarding usage.
316:  This information is used to shape the Turborepo roadmap and prioritize features.
317:  You can learn more, including how to opt-out if you'd not like to participate in this anonymous program, by visiting the following URL:
318:  https://turbo.build/repo/docs/telemetry
319:  turbo_json_parse_error
320:  x failed to parse turbo json
321:  Error: turbo_json_parse_error
322:  x Found an unknown key `tasks`.
323:  ,-[4:1]
324:  4 |   "globalEnv": ["NODE_ENV"],
325:  5 |   "tasks": {
326:  :   ^^^^^^^
327:  6 |     "build": {
328:  `----
329:  ##[error]Process completed with exit code 1.
330:  Post job cleanup.
331:  Pruning is unnecessary.
332:  Post job cleanup.
333:  [command]/usr/bin/git version
334:  git version 2.53.0
335:  Temporarily overriding HOME='/home/runner/work/_temp/5ba1beac-3b9b-41fd-ac36-ae4d6f564987' before making global git config changes
336:  Adding repository directory to the temporary git global config as a safe directory
337:  [command]/usr/bin/git config --global --add safe.directory /home/runner/work/opensourceframework/opensourceframework
338:  [command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand
339:  [command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
340:  fatal: No url found for submodule path 'pospos2' in .gitmodules
341:  ##[warning]The process '/usr/bin/git' failed with exit code 128
342:  Cleaning up orphan processes

- Adds new package under packages/bcryptjs
- Preserves original API
- Includes minimal smoke test

Fixes #108
The pnpm-lock.yaml was pinning turbo-linux-64@1.13.4 (Turbo v1)
while turbo@2.8.15+ was specified in devDependencies. This caused
all CI jobs to fail with 'Unknown key tasks' since Turbo v1 uses
'pipeline' instead of 'tasks' in turbo.json.

Regenerated lockfile with pnpm store prune + force install.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant