Conversation
IBDReduce was left out of docker at some point. This change adds it back
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker(Dockerfile): - jtb324 - 9/27/25 - 2:54pm
On branch update_docker
Changes to be committed:
added ibdreduce code to Dockerfile
IBDReduce was never added to the Dockerfile, likely due to unmerged code
at somepoint that was forgotten. I added all the necessary code and
built a "venv" that automatically is activated for the user. I also
added a requirements.txt file to the IDBReduce folder so that the
environment can be recreated. The user can now run the command "python /app/ibdreduce_v3.py -h" to see the help menu.
Corresponding updated the readme to reflect this changes about how to
run ibdreduce in the docker/singularity image and how to install
dependencies if you are installing from source.
Finally moved old version of IBDreduce into a folder called
"old_version". This change helps users understand which version of the
code to use