Skip to content

Fix #145 charging logics#146

Open
JakobWeg wants to merge 3 commits intodevfrom
fix-#145-charging_logics
Open

Fix #145 charging logics#146
JakobWeg wants to merge 3 commits intodevfrom
fix-#145-charging_logics

Conversation

@JakobWeg
Copy link
Copy Markdown
Contributor

@JakobWeg JakobWeg commented May 4, 2026

Fixes #145

Changes proposed in this pull request:

  • Including efficiency eta_cp

The following steps were realized (required):

  • [X ] Correct formatting with black src
  • [X ] Add the description of your changes to the CHANGELOG.md in subsection with release name [Unreleased] and state the PR number with #

Also the following steps were realized if applicable:

  • Write docstrings to your code
  • [X ] Write test(s) for new patch of code

@JakobWeg JakobWeg requested a review from mosc5 May 4, 2026 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] nominal_charging_capacity_kW refers to battery-side, not grid-side power — contradicts industry convention

1 participant