feat(deploy): add Render blueprint, make Chromium optional in image - #1073
feat(deploy): add Render blueprint, make Chromium optional in image#1073Swaray10 wants to merge 1 commit into
Conversation
|
. |
|
Thanks for this, @Swaray10 — and welcome to the repo. Straight answer up front: I'm not going to merge this as it stands. But there's a genuinely useful change buried in here, and I'd rather help you reshape it into something I can land than just close the tab. The detail below is meant to make a resubmission a short job rather than a guessing game. What's rightI checked these rather than taking the comments at their word, and they hold up:
The build arg is the half worth keeping — but it's gating the wrong thingThis is the part I'd like to land, and it isn't Render-specific at all: it helps every Baileys-only operator on bare Docker, Compose, and the Helm chart. I measured the published image on both architectures (compressed layer sizes, from the registry manifests):
The browser cost sits in a different layer on each architecture. On amd64 it's the Chrome-for-Testing download; on arm64 it's the That points at a much smaller change than the one you wrote. Gate only these two things:
That's roughly a three-line diff, and it captures the bulk of the saving on both architectures. What I'd leave alone is the collapse of the 17-package list into a multi-line quoted Also, the Two things the build-arg PR would need beyond the diff itself:
Correctness issues in
|
rmyndharis
left a comment
There was a problem hiding this comment.
Marking the review state so this is visible from the PR list — the substance is in my comment above, and nothing here is new.
Short version: I'd like to see this split. The INSTALL_CHROMIUM build arg is worth landing on its own terms; the root render.yaml is the half I'm not taking. Happy to look again at a resubmission along the lines I sketched, and no rush on it.
Description
Brief description of changes
Type of Change
Checklist
Screenshots (if applicable)
Related Issues
Closes #