docs(sdk): correct the Java release guide's missing-secret behaviour - #1086
Merged
Merged
Conversation
The Releasing section promised that until the publish secrets exist the workflow "cleanly no-ops (it prints a notice and skips the deploy), so tagging early is harmless". The workflow does the opposite and has for a while: the credential guard collects every missing secret and exits 1, precisely because a skipped deploy reporting green is indistinguishable from a real release in the run list. Left as-is: this file is not Prettier-clean on main and markdown is not gated by CI, so reformatting it here would bury a two-line correction in noise.
rmyndharis
force-pushed
the
docs/java-sdk-release-guard-is-a-hard-failure
branch
from
August 6, 2026 03:15
6e83871 to
ac12e90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sdk/java/README.md-> Releasing promised that until the publish secrets exist the workflow "cleanly no-ops (it prints a notice and skips the deploy), so tagging early is harmless".The workflow does the opposite, and deliberately so. The credential guard (
java-sdk-release.yml) collects every missing secret and exits 1, with its own comment explaining why: a skipped deploy that reports green is indistinguishable from a real release in the run list.Someone following the README would tag a release expecting a harmless run and get a red one instead — or, worse, trust the inverse promise while auditing why a release did not appear.
Noticed while auditing which SDKs actually publish automatically; unrelated to that work, so it is its own change.
Not reformatted: the file is not Prettier-clean on
mainand markdown is not gated by CI, so running the formatter here would bury a two-line correction in unrelated churn.