add .agents to .gitignore and add id.json for Indonesian locale. - #895
add .agents to .gitignore and add id.json for Indonesian locale.#895okabrionz wants to merge 2 commits into
Conversation
|
Thanks for the contribution! The Indonesian locale is well-structured and the translations look solid. However, there's a blocker below that needs to be fixed before this can merge, plus a couple of smaller points. Blocker:
|
rmyndharis
left a comment
There was a problem hiding this comment.
Thanks for the locale — the translations themselves read well, and the index.ts wiring is correct. A few things need fixing before this can merge:
-
id.jsonis invalid JSON (build-breaking).bulkRecipientsPlaceholdercontains a raw newline inside the string, soJSON.parsethrows and the dashboard build fails at import. The value should be a single line, same as the English source:"+62812345678". -
37 keys are missing relative to
en.json. The branch is behindmain— several recently landed features have no Indonesian strings:sessions.unlink.*,plugins.catalog.*,plugins.installModal.catalog*,sessionStatus.action_required / failed / authenticating,sessions.start.teardownPending*, and a few others. Please rebase and translate the full set (755 keys); untranslated keys silently fall back to English. -
One logical change per PR (CONTRIBUTING.md). The
.agents/.gitignoreentry is unrelated to the locale — please drop it from this PR (it also removes the file's trailing newline). -
Language label: use the native name, consistent with the other entries (
Français,한국어):Bahasa Indonesiainstead ofIndonesia.
Happy to re-review once these are addressed.
Description
This pull request adds support for the Indonesian (
id) language locale in the dashboard and updates.gitignoreto ignore the.agentsdirectory.Key Changes:
i18n / Localization:
Added
id.jsoncontaining full Indonesian translations for UI components, navigation, chats, and error messages.Registered
idinsupportedLanguages,languageOptions, andi18nsetup indashboard/src/i18n/index.ts.Repository Maintenance:
Added
.agents/to.gitignore.Type of Change
Checklist