Implement puzzle uniqueness #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robatron
reviewed
Dec 6, 2025
|
|
||
| // Default unique to true | ||
| unique = unique || true; | ||
| if(typeof unique === "undefined"){ |
robatron
reviewed
Dec 6, 2025
| By default, the puzzles are unique, uless you set `unique` to false. | ||
| By default, the puzzles are unique, unless you set `unique` to false. | ||
| (Note: Puzzle uniqueness is not yet implemented, so puzzles are *not* |
Owner
There was a problem hiding this comment.
This note can be deleted now since you've implemented this functionality 😄
robatron
reviewed
Dec 6, 2025
| // Check if "backwards" solution is equal to regular solution. | ||
| // If it is, the sudoku has a unique solution. | ||
| const reverseSolution = sudoku.solve(board, true); | ||
| if(reverseSolution == solution){ |
Owner
There was a problem hiding this comment.
We should use strict comparison here (===)
Owner
|
Hey, thanks for the PR, @larsbonczek! Love the bi-directional solving approach; clever use of existing functionality 👍 Left a few comments, but overall I think this is a pretty reasonable implementation! Let me know if you want to update those or if you'd like me to push the changes to your branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements puzzle uniqueness by checking whether the solution obtained by rotating through the possibilities in reverse matches the regular solution. If it does, only this one solution exists.
There is probably a better way to do this, but it seems to work.
Fixes #3