Skip to content

build: require Node 22.13 or newer#31

Merged
robert7 merged 3 commits into
mainfrom
codex/node-22-24-support
Jul 17, 2026
Merged

build: require Node 22.13 or newer#31
robert7 merged 3 commits into
mainfrom
codex/node-22-24-support

Conversation

@robert7

@robert7 robert7 commented Jul 16, 2026

Copy link
Copy Markdown
Owner

Summary

  • drop end-of-life Node.js 20 and require Node.js 22.13.0 or newer
  • use Node.js 24 LTS as the local development default
  • validate Node availability and the minimum version in node-check.sh
  • test Node.js 22.13.0 and 24 through the reusable CI matrix
  • update installation, development, troubleshooting, and changelog guidance

Tests

  • focused Node policy tests: 8 passed
  • ./code-quality.sh: 33 test files, 559 tests passed; coverage passed
  • npm run build
  • bash -n node-check.sh
  • workflow YAML parse
  • git diff --check

Dependency

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minimum required Node.js version to 22.13.0 and recommends Node.js 24 LTS for local development, updating the configuration files, documentation, and the node-check.sh script accordingly. Unit tests have also been added to verify the script and configuration alignment. The review feedback highlights robustness issues in the shell script's version parsing and .nvmrc reading, as well as a resource leak in the unit tests due to un-cleared temporary directories.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread node-check.sh
Comment thread node-check.sh
Comment thread test/unit/node-check-script.test.ts Outdated
@robert7
robert7 merged commit 1989238 into main Jul 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants