Skip to content

fix: allow structured leaf nodes without children#32

Draft
charleseze356 wants to merge 1 commit into
robert7:mainfrom
charleseze356:agent/fix-structured-children-schema
Draft

fix: allow structured leaf nodes without children#32
charleseze356 wants to merge 1 commit into
robert7:mainfrom
charleseze356:agent/fix-structured-children-schema

Conversation

@charleseze356

Copy link
Copy Markdown

What changed

Mark the children array optional for structured content nodes in the remnote_search and remnote_read_note output schemas. The property remains supported for non-leaf nodes.

Why

The RemNote bridge intentionally omits children for leaf nodes, but the MCP server output schema required it. Strict MCP clients therefore rejected otherwise valid large structured responses with a schema error.

Impact

  • Leaf nodes without children now validate correctly.
  • Nested nodes may still include children; recursive structured output is unchanged.
  • Markdown output, input schemas, and RemNote write behavior are unaffected.
  • Tools inheriting the search result schema receive the corrected contract.

Validation

  • Full unit suite: 554 tests passed
  • TypeScript typecheck passed
  • Lint passed
  • Formatting check passed
  • Production build passed
  • MCPB generated-metadata check passed
  • Live RemNote server and bridge reconnected on v0.17.0, and a fresh Codex task advertised children? in the structured output schema

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the output schemas for the remnote_search and remnote_read_note tools to mark the children array of structured content nodes as optional, matching bridge responses that omit children for leaf nodes. It also updates the schema descriptions, adds a unit test to verify this behavior, and documents the change in CHANGELOG.md. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant