Compilation warning fixes, small bugfixes #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes resolve the compilation errors in the Arduino IDE by discarding an unnecessary variable from flush() and explicitly typecasting trk from int to uint16_t for the comparison operation in isTrackPlaying(int trk).
This corrects an out-of-bounds character array issue which can occur when calling getVersion, due to an unnecessary prefix increment which is already handled by the update function.
nomakewan
changed the title
Missed the erroneous break statement which is unnecessary since update() already handled the bounds checking and version array cleaning.
This corrects errors related to AltSoftSerial, enforcing the use of the standard Arduino Library for it rather than a hardcoded path to its header file. It also updates the README accordingly.
nomakewan
changed the title
Fixes newly-created compiler error due to removing the unused parameter from getVersion.
Updates the README to match the current code of this PR.
Checks to see if the user's board is a Due or its derivatives and if so includes Arduino.h instead of HardwareSerial.h since that is where the serial ports are defined on the Due.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes resolve the compilation errors in the Arduino IDE by discarding an unnecessary variable from flush() and explicitly typecasting trk from int to uint16_t for the comparison operation in isTrackPlaying(int trk).
Additionally this PR corrects an out-of-bounds character array issue in the getVersion() function that was double-dipping the version character array cleaning process which was already handled sufficiently by update(). Resolves #28
This PR also adds a define for the Arduino Due to include Arduino.h for serial ports rather than HardwareSerial.h, which Resolves #16
Finally, this PR changes the hardcoded path to AltSoftSerial's header file to use the Arduino Library instead, which simplifies sketches and Resolves #18