Fixes for ESP32 #34
Open
Fixes for ESP32 #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the macros for hardware serial aren't set, fall back to softserial. If any one of them are set, don't set the softserial macro and don't include the softserial lib.
This maps the logical serial port numbers to the internal ones used by the macro, while also making use of my previous patch that avoids having to edit the library directly. Instead, on Arduino, the user can simply leave macros unset unless they don't want to use software serial, and on ESP32 we throw a compile error if one of the hardware serial macros aren't set. I opted to forego the option for hardware serial since picking which implementation of software serial for ESP32 to use is a big step. That task would be more suited to Robert himself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This maps the logical serial port numbers to the internal ones used by the internal macro, while also making use of my previous patch that avoids having to edit the library directly. Instead, on Arduino, the user can simply leave macros unset unless they don't want to use software serial, and on ESP32 we throw a compile error if one of the hardware serial macros aren't set.
I opted to forego the option for hardware serial since picking which implementation of software serial for ESP32 to use is a big step. That task would be more suited to yourself.